#41 enhancement to support ng-disabled #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QuickDate into disabled-binding Conflicts: spec/basic-specs.coffee
|
@seibar Hey man! Great PR, tough there are some conflicts. If you want we can do a pair programming session to resolve them, or you can resolve them on your own. Let me know what suits you best! Otherwise everything else looks good to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41
I added a binding to watch ngDisabled. When disabled is true, the button is grayed-out, the cursor changes to 'not-allowed', and the date picker does not open. It also does not open if the user sets focus by tabbing to the button.
I also updated demo.html to demonstrate the disabled functionality.
Also added a couple of tests.