Fix regression of keypad.*.reset() behavior: send key_pressed events #9819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aseanwatson pointed out that there was a regression from 9.0.0 to 9.1.0 for
keypad.*.reset()
. It started sendingkey_released
instead ofkey_pressed
events. @aseanwatson also figured out the fix (thanks!), which is what is here.Also documents how to use
reset()
to determine which keys are held down at program startup.Fixes #9818, by fixing the mentioned bug.
Using
reset()
to determine pressed keys makes a new API unneeded (tagging @todbot on this).Tested on a CPB:
Confirmed that it worked in 9.0.0, gave the wrong events in 9.1.0, and is fixed by the change.