Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added polling flag to MultiTrellis::read #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ukmaker
Copy link

@ukmaker ukmaker commented May 21, 2022

Theread()method in MultiTrellis does not currently support the polling flag. This results in unnecessary bus activity which injects noise in to the PSU for audio applications.

This PR adds the flag, default to true if not supplied so as not to change the API for existing apps.

This PR also duplicates the logic if (polling) count = count + 2; which exists in the NeoTrellis::read(0 method. However I have no idea what this actually does (there is no comment explaining it). But it works for me :-)

@ladyada
Copy link
Member

ladyada commented May 21, 2022

hiya! thanks so much for submitting a PR! we can review & merge PRs once they have passed continuous integration (CI). that means that code compiles cleanly for all tested platforms, is clang formatted so we maintain the same text formatting for all new code, and is doxygen documented.
if your code isnt passing, check the CI output (click on the red X next to the PR to scroll through the log and find where the error is

here is a tutorial on doxygen: https://learn.adafruit.com/the-well-automated-arduino-library/doxygen

and clang-format: https://learn.adafruit.com/the-well-automated-arduino-library/formatting-with-clang-format

and overall how to contribute PRs to libraries: https://learn.adafruit.com/contribute-to-arduino-with-git-and-github

once you get that green checkmark that indicates CI has passed, please comment reply to this post so we know its time for another review (we may not get notified on CI pass and miss that its time to look!)

@ukmaker
Copy link
Author

ukmaker commented May 22, 2022

I hope this is useful! Not having to poll also frees up valuable CPU cycles for other things

@ukmaker
Copy link
Author

ukmaker commented Jun 8, 2022

Hi there. Will these be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants