Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: submitting ideas for example code #67

Merged
merged 10 commits into from
Jun 16, 2024
Merged

Conversation

johnnohj
Copy link
Contributor

@johnnohj johnnohj commented Jun 4, 2024

Suggested changes prompted by issues #45 and #46 .

The asyncio_simpletest.py referenced in #45 seemed easily corrected with code from the excellent Cooperative Multitasking tutorial. For #46 , there still is no code posted by the original author almost a year later, so I submit a draft of code, asyncio_event_example.py, I worked up as an exercise for a larger project, and which I hope might be a useful model for anyone else intimidated or stymied by the readthedocs information.

@johnnohj johnnohj marked this pull request as draft June 4, 2024 15:21
@dhalbert
Copy link
Contributor

dhalbert commented Jun 6, 2024

Check out using pre-commit, which will let you check formatting issues before you push:
https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@johnnohj
Copy link
Contributor Author

johnnohj commented Jun 6, 2024

Check out using pre-commit

I certainly will - I hope my amateurishness wasn't disruptive.
That said, I think I've done all I can to satisfy the checks. The rest is beyond me. Further help and guidance would be greatly appreciated.

@dhalbert
Copy link
Contributor

dhalbert commented Jun 6, 2024

The remaining fixes look like comment indentation and using double quotes instead of single quotes. If you install pre-commit, it will take care of all this for you. The changes needed will be done automatically when the code is reformatted with black. See https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/black. Pre-commit runs black for you with the right settings.

@johnnohj johnnohj marked this pull request as ready for review June 6, 2024 22:02
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples look good to me.

Thanks for working on this @johnnohj!

@FoamyGuy FoamyGuy merged commit 2032ac1 into adafruit:main Jun 16, 2024
1 check passed
@johnnohj
Copy link
Contributor Author

Hey, cool beans! Navigating Git(Hub) as a novice wasn't the most enjoyable part of the process, but worth the bother to give back to the community in some small way. This ought to resolve issue #45 (I think?), and should at least help begin to answer #46 . Thank you, @dhalbert and @FoamyGuy !

Now, back to working on the driver for the VL53L1X sensor :)

This was referenced Jun 17, 2024
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants