-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: submitting ideas for example code #67
Conversation
Simple copy/paste beginning from https://learn.adafruit.com/cooperative-multitasking-in-circuitpython-with-asyncio/concurrent-tasks#one-led-3106269 to correct an issue raised, of all places, in the Issues section.
Corrections to code made based on test results.
Check out using |
I certainly will - I hope my amateurishness wasn't disruptive. |
The remaining fixes look like comment indentation and using double quotes instead of single quotes. If you install pre-commit, it will take care of all this for you. The changes needed will be done automatically when the code is reformatted with |
…5gv7xv555qv7277r5 Pending changes exported from your codespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples look good to me.
Thanks for working on this @johnnohj!
Hey, cool beans! Navigating Git(Hub) as a novice wasn't the most enjoyable part of the process, but worth the bother to give back to the community in some small way. This ought to resolve issue #45 (I think?), and should at least help begin to answer #46 . Thank you, @dhalbert and @FoamyGuy ! Now, back to working on the driver for the VL53L1X sensor :) |
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#67 from johnnohj/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.3.1 from 5.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#58 from ilikecake/file_flush_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Suggested changes prompted by issues #45 and #46 .
The asyncio_simpletest.py referenced in #45 seemed easily corrected with code from the excellent Cooperative Multitasking tutorial. For #46 , there still is no code posted by the original author almost a year later, so I submit a draft of code, asyncio_event_example.py, I worked up as an exercise for a larger project, and which I hope might be a useful model for anyone else intimidated or stymied by the readthedocs information.