chore: make traceback module optional #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
chore/optional-traceback
branch
2 times, most recently
from
f317420 to
82bd1e8
Compare
some boards don't provide traceback so we can add a minimal implementation that works _good enough_ in those cases so asyncio can still be used
imnotjames
force-pushed
the
chore/optional-traceback
branch
from
82bd1e8 to
8d69d54
Compare
FoamyGuy
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
This looks good and makes sense to me. I did not run it on a device, but did review code for the fallback mechanism.
Thank you @imnotjames!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.1.0 from 1.0.12: > Merge pull request adafruit/Adafruit_CircuitPython_24LC32#23 from TonyLHansen/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 2.0.0 from 1.3.13: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#24 from jposada202020/improving_lib Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 3.1.0 from 3.0.17: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#61 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.14 from 3.4.13: > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#59 from bdlucas1/main Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.8.1 from 5.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#114 from kavinaidoo/main Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#59 from imnotjames/chore/optional-traceback Updating https://github.com/adafruit/Adafruit_CircuitPython_PyCamera to 0.0.7 from 0.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#15 from adafruit/enhancements > Merge pull request adafruit/Adafruit_CircuitPython_PyCamera#13 from brentru/allow-jpg-save Updating https://github.com/adafruit/Adafruit_CircuitPython_TemplateEngine to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TemplateEngine#2 from michalpokusa/removing-8-x-x-re-module-bug-workarounds Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some boards don't provide traceback, but adafruit_asyncio seems to require it
if #57 is considered an issue (and not an intended behavior) then this should fx it by adding a minimal implementation of traceback's
print_exceptionthat works good enough in those cases so asyncio can still be used and there's still a reasonable path for debuggingfixes #57