-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add queue support #50
base: main
Are you sure you want to change the base?
Conversation
I don't see an easy way to add tests - they don't seem to exist for this repo. Happy to change as needed. |
Err, ok, it's missing copyright info in the file. Should I use the same one from the other where it references the micropython license? |
You can use |
Yes, you can copy the original copyright. |
Got it, added! |
@@ -0,0 +1,145 @@ | |||
# SPDX-FileCopyrightText: 2019-2020 Damien P. George |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDX-FileCopyrightText: Copyright (c) 2023 Your Name Here / Handle? for Adafruit Industries ? What's the right approach here? it seems wrong copying this copyright verbatim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @dhalbert I copied the original copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"for Adafruit Industries" is when someone got paid to do the work.
this is the norm for accessing from core
f23de4e
to
ea4f3d1
Compare
Added some tests - once #58 is merged in these confirm the Queue behavior |
@imnotjames this was passing the current actions at commit f94cfb3, but no longer is. I'm not sure of the current state of the discussion or issues that you noted in #58 around testing but perhaps we can raise that topic during a weekly meeting (next one is scheduled for Jan 2nd) if you want to try to move the discussion forward and get more folks involved. In the meantime if you're interested / willing if you can get this branch back to the state it was at for |
The issue is that there are tests which pytest is trying to run but it can't because they aren't pytest. I can drop these tests for now and eventually merge them into the circuitpython core; It just means that the queue is "untested". |
I'm going to drop that commit and force push to remove it from the history of this PR. I'll save them as a gist: https://gist.github.com/imnotjames/d281bc6a6a7cc6fc964e30e080560ed8 |
ea4f3d1
to
f94cfb3
Compare
add implementation for
asyncio.Queue
that matches python'sasyncio
signature forQueue
Fixes #6