Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20 fixes #49

Merged
merged 1 commit into from
Oct 12, 2023
Merged

1.20 fixes #49

merged 1 commit into from
Oct 12, 2023

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Oct 10, 2023

#47 should be merged before this.

@tannewt tannewt requested a review from dhalbert October 10, 2023 21:10
dhalbert
dhalbert approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There is a yield on line 88 in event.py; I am not sure that will work for us. However, it's in our old version too, so that's not some thing new.

@tannewt tannewt marked this pull request as ready for review October 12, 2023 22:06
dhalbert
dhalbert approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will immediately re-release.

@dhalbert dhalbert merged commit c277db5 into adafruit:main Oct 12, 2023
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 13, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@87f545d)
4c806d6 
Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.1.0 from 0.5.24:
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#49 from tannewt/1.20-fixes
  > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#47 from adafruit/9.0.0-updates

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_AD569x

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert