Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pycamera #446

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Add pycamera #446

merged 2 commits into from
Dec 5, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Nov 30, 2023

Note: pypi and rtd links are not yet in place so they are expected to be 404'd at this time

@jepler jepler requested a review from a team November 30, 2023 13:29
@tannewt
Copy link
Member

tannewt commented Nov 30, 2023

From CI:

Run circuitpython-build-bundles --filename_prefix adafruit-circuitpython-bundle --library_location libraries --library_depth 2 --package_folder_prefix "adafruit_, asyncio"
fatal: No names found, cannot describe anything.
fatal: run_command returned non-zero status for helpers/pycamera
.
/home/runner/work/Adafruit_CircuitPython_Bundle/Adafruit_CircuitPython_Bundle/libraries/drivers/libraries has version that doesn't follow SemVer (semver.org)
20231130 is not valid SemVer string

@jepler
Copy link
Member Author

jepler commented Nov 30, 2023

Thanks! I'll get to it, but there's other stuff also blocking this from going in so it wasn't a priority today.

jepler added 2 commits December 5, 2023 11:06
@jepler
remove copy of vcnl4020 in wrong location
ca9cd21 
This is what would cause the diagnostic at bundle build time:
```
.../Adafruit_CircuitPython_Bundle/libraries/drivers/libraries has version that doesn't follow SemVer (semver.org)
```

There's a copy of the driver at the correct location.
@jepler
Add pycamera
0e60b19 
pypi and rtd links are not yet in place
dhalbert
dhalbert approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dhalbert dhalbert merged commit 6f73f45 into adafruit:main Dec 5, 2023
1 check passed
@jepler jepler deleted the add-pycamera branch December 5, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepler @tannewt @dhalbert