🚿 Remove redundant substring() + test cases

acusti · Mar 15, 2024 · 99fbc6c · 99fbc6c
1 parent 34e35cc
commit 99fbc6c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/textual/src/index.test.ts b/packages/textual/src/index.test.ts
@@ -67,6 +67,8 @@ describe('@acusti/text-transform', () => {
             expect(getInitials('BigO')).toBe('BO');
             expect(getInitials(' "LastPass"')).toBe('LP');
             expect(getInitials(' "LastP4ss"')).toBe('LP4');
+            expect(getInitials('LastPassFirstTask')).toBe('LPF');
+            expect(getInitials('LastPassFirstTask', 4)).toBe('LPFT');
             // if initials would be only numbers, include 1st letter (if present)
             expect(getInitials('4ty')).toBe('4T');
         });

diff --git a/packages/textual/src/index.ts b/packages/textual/src/index.ts
@@ -18,7 +18,7 @@ export const getInitials = (name: string, maxLength = 3) => {
     let initials = '';
     // for single word names, use uppercase letters and numbers
     if (!name.includes(' ')) {
-        initials = name.replace(SINGLE_WORD_NON_INITIALS_REGEX, '').substring(0, maxLength);
+        initials = name.replace(SINGLE_WORD_NON_INITIALS_REGEX, '');
         // if initials are only numbers, include 1st letter (if present)
         if (!/[a-zA-Z]/.test(initials)) {
             initials += name.replace(/[^A-Za-z]+/, '')[0];