Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizing documentation since SimpleFIN will be officially released #2 #459

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Reorganizing documentation since SimpleFIN will be officially released #2 #459

wants to merge 27 commits into from

Conversation

Jonathan-Fang
Copy link
Contributor

@Jonathan-Fang Jonathan-Fang commented Sep 25, 2024 •
edited
Loading

  • removed simplefin from experimental tab
  • added mention of simplefin in bank-sync
  • split bank-sync into gocardless and simplefin
  • created dropdown for bank-sync
  • proofreaded punctuation & image alignment in gocardless and simplefin guides

Fixes #452, #453 and fixes #454

I'm not sure why #458 got closed, so I'm making a new one here.

@actual-github-bot actual-github-bot bot changed the title Simplefin not experimental [WIP] Simplefin not experimental Sep 25, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for actualbudget-website ready!

Name Link
🔨 Latest commit 2b824fe
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget-website/deploys/66f51e45d39f5c00081c5cbf
😎 Deploy Preview https://deploy-preview-459.www.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jonathan-Fang Jonathan-Fang mentioned this pull request Sep 25, 2024
Closed
@Jonathan-Fang Jonathan-Fang changed the title [WIP] Simplefin not experimental [WIP] Reorganizing documentation since SimpleFIN will be officially released #2 Sep 25, 2024
@Jonathan-Fang Jonathan-Fang changed the title [WIP] Reorganizing documentation since SimpleFIN will be officially released #2 Reorganizing documentation since SimpleFIN will be officially released #2 Sep 25, 2024
matt-fidd
matt-fidd requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
A few quick first pass comments

docs/advanced/bank-sync.md Outdated Show resolved Hide resolved
docs/advanced/bank-sync/simplefin.md Outdated Show resolved Hide resolved
docs/advanced/bank-sync/simplefin.md Show resolved Hide resolved
docs-sidebar.js Outdated Show resolved Hide resolved
docs/advanced/bank-sync.md Show resolved Hide resolved
@Jonathan-Fang Jonathan-Fang changed the title Reorganizing documentation since SimpleFIN will be officially released #2 [WIP] Reorganizing documentation since SimpleFIN will be officially released #2 Sep 26, 2024
@Jonathan-Fang Jonathan-Fang changed the title [WIP] Reorganizing documentation since SimpleFIN will be officially released #2 Reorganizing documentation since SimpleFIN will be officially released #2 Sep 26, 2024
Jonathan-Fang
Jonathan-Fang commented Sep 26, 2024
View reviewed changes
Copy link
Contributor Author

@Jonathan-Fang Jonathan-Fang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for another review!

matt-fidd
matt-fidd approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
I won't merge it until the release goes out so the docs stay in line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-fidd matt-fidd matt-fidd approved these changes

@RubenOlsen RubenOlsen Awaiting requested review from RubenOlsen

Assignees
No one assigned
Labels
✅ Approved
Projects
None yet
Milestone
No milestone
3 participants
@Jonathan-Fang @matt-fidd @youngcw