Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:electron: security.js and preload.js ➡️ .ts #3066

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Jul 16, 2024

Updated security.js and preload.js to Typescript and fixed Theme not setting correctly when set via dev console

#1483

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4f435b7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/669830778692040008fa56b8
😎 Deploy Preview https://deploy-preview-3066.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 76.19 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.61 kB 0%
static/js/wide.js 274.1 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 2.99 MB 0%

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

@MikesGlitch MikesGlitch changed the title [WIP] :electron: security.js and preload js ➡️ .ts :electron: security.js and preload js ➡️ .ts Jul 16, 2024
@MikesGlitch MikesGlitch changed the title :electron: security.js and preload js ➡️ .ts :electron: security.js and preload.js ➡️ .ts Jul 16, 2024
@MikesGlitch MikesGlitch marked this pull request as ready for review July 16, 2024 17:10
MatissJanis
MatissJanis previously approved these changes Jul 17, 2024
packages/desktop-electron/preload.ts Outdated Show resolved Hide resolved
@MatissJanis MatissJanis merged commit f75d0f8 into actualbudget:master Jul 17, 2024
19 checks passed
@MikesGlitch MikesGlitch deleted the ts/electron-security-and-prelod branch July 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants