[Maintenance] Update ConfirmCategoryDelete, GoCardlessExternalMsg, ManageRulesModal to tsx #1972
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -140,7 +155,6 @@ export default function GoCardlessExternalMsg({ | |||
| <Autocomplete | |||
| strict | |||
| highlightFirst | |||
| disabled={isConfigurationLoading} | |||
There was a problem hiding this comment.
Not a valid prop on autocomplete. If we want to disable it we set the "inputProps" prop
MikesGlitch
changed the title
| return ( | ||
| <Modal | ||
| title="Rules" | ||
| padding={0} | ||
| loading={loading} | ||
| {...modalProps} | ||
| style={{ | ||
| ...modalProps.style, |
There was a problem hiding this comment.
Not a valid prop on modalProps and never set. Must be old.
MikesGlitch
force-pushed
the
maintenance/modals-to-tsx
branch
from
eef98f1
to
aaae4fd
Compare
…aintenance/modals-to-tsx
|
Safe to merge so breaking merge-freeze here. Only type changes that do no affect customer experience. And removal of two things that have very good justification (also double checked myself). SAFE |
trafico-bot
bot
added
✨ Merged
…nageRulesModal to tsx (actualbudget#1972)
Update ConfirmCategoryDelete, GoCardlessExternalMsg, ManageRulesModal to tsx
#1483