Budget tsx refactor #1743
Merged
Budget tsx refactor #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
👋 Would you mind taking a look at the failing lint job? Sadly without having all the CI jobs passing we won't be able to merge. |
* regression fixes * notes * VRT updates
* 🔖 (23.10.0) * Remove used release notes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Editable mobile budget * Fix error on empty amount * Fix typo * Decimal keyboard + select input on click * Remove scrollIntoView * Fix focus * Focus input on negative/positive * Use CellValue * Functional mobile components * Blur fix c/o dmlazaro * Use pointer event * Remove useFireChangeOnUnmount * Release notes * Prevent default on pointerdown * Add dmlazaro to release notes * Disable amount input button when not focused * Remove input refocus
MatissJanis
approved these changes
Oct 6, 2023
Comment on lines
-30
to
-31
| editingIndex={undefined} | ||
| args={undefined} |
trafico-bot
bot
added
✅ Approved
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the following to tsx: IncomeGroup, IncomeHeader, MonthsContext, RenderMonths, SidebarGroup.
Related to issue #1483
I had some trouble with RenderMonths, specifically typing 'Component' and returning a JSX.Element when a JSX.Element[] was the expected return type.
I also had an issue with MonthsContext and eslint not recognizing that 'getValidMonthBounds' and 'MonthsProvider' were being imported and used elsewhere.
If anyone has suggestions on these or anything else please let me know and I can fix it right away.