refactor: provide type in useSendPlatformRequest to infer in usages

actualbudget · Nov 22, 2023 · ecad163 · ecad163
1 parent a00c7e4
commit ecad163
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx b/packages/desktop-client/src/components/schedules/DiscoverSchedules.tsx
@@ -2,7 +2,6 @@ import React, { useState } from 'react';
 
 import q, { runQuery } from 'loot-core/src/client/query-helpers';
 import { send } from 'loot-core/src/platform/client/fetch';
-import { type SchedulesHandlers } from 'loot-core/src/server/schedules/types/handlers';
 import { getRecurringDescription } from 'loot-core/src/shared/schedules';
 import type {
   DiscoverScheduleEntity,
@@ -130,10 +129,7 @@ export default function DiscoverSchedules({
   modalProps: CommonModalProps;
   actions: BoundActions;
 }) {
-  const { data, isLoading } = useSendPlatformRequest('schedule/discover') as {
-    data: Awaited<ReturnType<SchedulesHandlers['schedule/discover']>> | null;
-    isLoading: boolean;
-  };
+  const { data, isLoading } = useSendPlatformRequest('schedule/discover');
 
   const schedules = data || [];
 

diff --git a/packages/desktop-client/src/hooks/useSendPlatformRequest.ts b/packages/desktop-client/src/hooks/useSendPlatformRequest.ts
@@ -8,7 +8,7 @@ export default function useSendPlatformRequest<K extends keyof Handlers>(
   args?: Parameters<Handlers[K]>[0],
   options?: { catchErrors?: boolean },
 ) {
-  const [data, setData] = useState<unknown>(null);
+  const [data, setData] = useState<Awaited<ReturnType<Handlers[K]>>>(null);
   const [isLoading, setIsLoading] = useState<boolean | null>(null);
 
   useEffect(() => {

diff --git a/packages/loot-core/src/server/schedules/find-schedules.ts b/packages/loot-core/src/server/schedules/find-schedules.ts
@@ -394,11 +394,10 @@ export async function findSchedules() {
     },
   );
 
-  const finalized = [];
+  const finalized: Awaited<ReturnType<SchedulesHandlers['schedule/discover']>> =
+    [];
   for (let schedule of schedules) {
     finalized.push(await findStartDate(schedule));
   }
-  return finalized as unknown as Awaited<
-    ReturnType<SchedulesHandlers['schedule/discover']>
-  >;
+  return finalized;
 }