feat: TGeo python binding #3885
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| /// @param sensitiveMatches is a list of strings to match sensitive volumes | ||
| /// @param localAxes is the TGeo->ACTS axis conversion convention | ||
| /// @param convertMaterial is a flag to convert the material | ||
| tgeo.def("convertToElements", |
There was a problem hiding this comment.
If this is an internal function, maybe _convertToElements?
There was a problem hiding this comment.
Ok, are we doing this consistently now?
I am happy to change, I've also added some information why this method is useful.
There was a problem hiding this comment.
It's not well defined what internal means, but the comment mentions this being a "helper function to test" something. It's not currently called in a test anywhere, so I'm not entirely sure how this is supposed to be used.
|
This PR adds some first python bindings for the
TGeoplugin.The added functionality is mainly for testing reason, it allows to you test whether sensitive elements from a
TGeodescription (or those one picks as sensitive) can be translated into TGeoDetectorElements.--- END COMMIT MESSAGE ---