Reworded a sentence, for easier understanding. #1096
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.emailin their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL")
✅ Deploy Preview for activist-org canceled.
|
| @@ -96,7 +96,7 @@ Please see the [contribution guidelines](CONTRIBUTING.md) and [style guide](STYL | |||
|
|
|||
| Also check the [`-next release-`](https://github.com/activist-org/activist/labels/-next%20release-) and [`-priority-`](https://github.com/activist-org/activist/labels/-priority-) labels in the [issues](https://github.com/activist-org/activist/issues) for those that are most important, as well as those marked [`good first issue`](https://github.com/activist-org/activist/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) that are tailored for first time contributors. For those new to coding or our tech stack, we've collected [links to helpful documentation pages](CONTRIBUTING.md#learning-the-tech) in the [contribution guidelines](CONTRIBUTING.md). | |||
|
|
|||
| We would be happy to discuss granting you further rights as a contributor after your first pull requests, with a maintainer role then being possible after continued interest in the project. activist seeks to be an inclusive, diverse and supportive organization. We'd love to have you on the team! | |||
| We would be happy to discuss granting you further rights as a contributor after your first pull request, with the possibility of a maintainer role following continued interest in the project. activist seeks to be an inclusive, diverse and supportive organization. We'd love to have you on the team! | |||
There was a problem hiding this comment.
I appreciate your interest in helping us with the documentation, @EmilsBalandins, but I think we'll leave it as it is. Further rights as a contributor would follow pull requests, not a single pull request, and I feel that the second clause is fine as it is.
Let us know if you see something else! Appreciate the checks for sure 😊
There was a problem hiding this comment.
To be fair though, the statement feels grammatically weird as it is at the moment. and the correct way (if you mean multiple pull requests) would be "your first few pull requests" and not "your first pull requests"
All in all, I honestly think this is a better improvement and should be changed
Contributor checklist
Description
My first pull request to study about git, made a slight change in grammatical wording for easier understanding.