Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#546 Base i18n map object and process to create it #1092

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

andrewtavis
Copy link
Member

Contributor checklist


Description

This PR is the final part of the planned functionality of i18n-check, with these commits being added to the i18n-check repo. Specifically we discussed the potential to load all i18n keys into a generated map object that would then type check all use cases of the keys to make sure that none are misspelled. This is of particular importance for aria labels where the key being misspelled will not be evident to the development team.

Once this is merged a new issue will be opened to switch all keys over to the i18nMap object. As of now it's only used in the search bar component for the word Search.

Related issue

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit be179f2
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67896a02e2e1160008a22286
😎 Deploy Preview https://deploy-preview-1092--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member Author

CC @OmarAI2003 as this adds functionality to i18n-check. As stated, I'll add this into the repo when this is merged :)

@andrewtavis
Copy link
Member Author

Checks passed and the map object does load the i18n key into the component, so merging this in 😊

@andrewtavis andrewtavis merged commit 58e5f1f into main Jan 16, 2025
7 checks passed
@andrewtavis andrewtavis deleted the 546-base-i18n-obj branch January 16, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant