Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Forcing UTF-8 encoding and adding support for 'with' clause #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Forcing UTF-8 encoding and adding support for 'with' clause #62

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2011

Hello,

  1. I've found when I try and import an entry from a database that contains the 'ü' character I get a 'from ASCII-8BIT to UTF-8' error. I have added a fix for this by forcing the 'UTF-8' encoding.
  2. I've also added code that supports the sql 'WITH' clause.

Thank you.

@thbar
Copy link
Member

thbar commented Nov 3, 2011

Hi! Thanks for your patch first, appreciated :)

Are you able to provide a working test for 9ef0ffd and 2cc25e1? I could merge it right away!

On 081ae88: I won't apply this one for the following reasons:

  • one can use force_encoding at the row level without us making any assumption
  • force_encoding doesn't work with 1.8.7
  • some people are outputting data in latin1 or other encoding

Hope you're ok with this! (but thanks anyway)

-- Thibaut

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant