UI-9786 - Explicitly preserve the default measure when migrating from 4.3 to 5.0 #130
Conversation
|
|
||
| const cube = dataModelsForTests.sandbox.catalogs[0].cubes[0]; | ||
|
|
||
| describe("_addDefaultMeasureIfNoneIsExplicitlyExpressed", () => { |
There was a problem hiding this comment.
It would be nice to add a test ensuring that the function does not early-return by mistake when the query does not contain any measure but a hierarchy is sorted. For instance:
WITH
Member [Measures].[[Currency]].[Currency]].[Currency]]_for_order] AS Rank(
[Currency].[Currency].CurrentMember,
[Currency].[Currency].Members
)
SELECT
NON EMPTY Order(
Hierarchize(
Descendants(
{
[Currency].[Currency].[ALL].[AllMember]
},
1,
SELF_AND_BEFORE
)
),
[Measures].[[Currency]].[Currency]].[Currency]]_for_order],
DESC
) ON ROWS
FROM [EquityDerivativesCube]
I expect [Measures].[contributors.COUNT] to be added in this query.
@Nouzbe This happens only for hierarchies on columns, if there is a hierarchy on columns, but no measure expressed, the default measure is shown on AUI-4
|
| * - not displayed in Atoti 5.0 | ||
| * This function explicitly adds it to the MDX so that it is isofunctional for the user. | ||
| */ | ||
| export function _addDefaultMeasureIfNoneIsExplicitlyExpressed( |
There was a problem hiding this comment.
On AUI-4, the default measure is only displayed when there is a hierarchy on columns with no explicit measures. It might be good to modify this function so that the measure is only explicitly added to the query in that scenario. Right now, it adds the measure if a hierarchy is expressed in either the rows or columns axis, which is technically not isofunctional to what AUI-4 does. Thoughts @Nouzbe ?
There was a problem hiding this comment.
See the behavior of AUI-4 below:
Screen.Recording.2024-10-04.at.10.43.33.AM.mov
…re exists a hierachy on columns and no measures are explicitly expressed.
…ns axis contains a sorted hierachy.
|
I've added some commits to this PR to align the migration script's functionality with that of AUI-4. On AUI-4, the default measure was only added when no measures were expressed and the query contained at least hierarchy on the columns axis. The default measure was not added when the columns axis was empty. See this video for details. @Nouzbe @antoinetissier Let me know if you agree/disagree with the changes. We can drop the new commits if you disagree with the changes. |
antoinetissier
deleted the
personal/a.tissier/preserve-default-measure
branch
See UI-9786 and/or the multiline comment of
_addDefaultMeasureIfNoneIsExplicitlyExpressedto understand the issue and the fix.