UI-8803 - Support namespaces in XML calculated members #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinetissier
deleted the
personal/a.tissier/UI-8803-parse-cms-with-namespace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See UI-8803, and the added test: the problem is that the
calculatedMembertag in the customer's XML is prefixed with a namespace (ns2).Adding a tag processor allows to remove it from the parsed JSON.
Note that when migrating all the way from 4.3 to 5.1, then:
I honestly think it's fine, and would prefer for clients to report an issue before trying to preserve it.
For example, in this example from the customer,
ns2is actually a dummy namespace that should only be used in test cases.