Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails 7.2 loading #1534

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    1ad129a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a26e251 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e9f20f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4ece2c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Requiring more pieces of ActiveSupport

    I am not sure whether going down this path is the best approach. I feel
    that perhaps ActiveSupport could require everything within
    active_support/core_ext to ensure that active_support/core_ext can load
    itself. Still, there's no changing old versions of Rails, so I suppose
    this solution works? I am also not sure what the Rails team would
    recommend when it comes to requiring specific pieces of ActiveSupport
    (to leverage things like mattr_accessor).
    
    In any case, I was able to reproduce the CI failures locally and these
    changes make everything pass for me locally.
    jdlubrano committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    046bae7 View commit details
    Browse the repository at this point in the history