Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cache service v2 #1857

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Integrate cache service v2 #1857

wants to merge 47 commits into from

Conversation

Link-
Copy link
Member

@Link- Link- commented Oct 24, 2024

Upgrading the cache package to integrate with the new cache service backend (cache service v2). Major changes to the API layer are involved with this change but the interfaces are backward compatible. The transition to the new service will undergo gradual rollout and will be seamless to end users.

More context

Deprecation notice for v1 and v2 of actions/cache

@Link- Link- self-assigned this Oct 24, 2024
package.json Outdated Show resolved Hide resolved
packages/cache/package.json Outdated Show resolved Hide resolved
packages/cache/src/internal/config.ts Outdated Show resolved Hide resolved
Liabaemt

This comment was marked as spam.

@Liabaemt

This comment was marked as spam.

@Link- Link- marked this pull request as ready for review November 14, 2024 12:02
@Link- Link- requested review from a team as code owners November 14, 2024 12:02
@Link- Link- requested a review from robherley November 14, 2024 12:52
package.json Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Outdated Show resolved Hide resolved
@Link- Link- requested a review from a team as a code owner November 20, 2024 22:02
@Link- Link- requested a review from johnsudol November 20, 2024 22:22
Copy link
Contributor

@robherley robherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking comments, 👍 given we'll follow up in future PRs with more test coverage before release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it would be great if we could share this client between the artifact and cache packages

packages/cache/src/internal/blob/download-cache.ts Outdated Show resolved Hide resolved
packages/cache/src/internal/blob/upload-cache.ts Outdated Show resolved Hide resolved
packages/cache/src/cache.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants