artifact(download): skip non-zip files

actions · Nov 13, 2024 · 17ec324 · 17ec324
1 parent bb2278e
commit 17ec324
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 13 deletions.
diff --git a/packages/artifact/src/internal/download/download-artifact.ts b/packages/artifact/src/internal/download/download-artifact.ts
@@ -37,12 +37,11 @@ async function exists(path: string): Promise<boolean> {
   }
 }
 
-async function streamExtract(url: string, directory: string): Promise<void> {
+async function streamExtract(url: string, directory: string): Promise<boolean> {
   let retryCount = 0
   while (retryCount < 5) {
     try {
-      await streamExtractExternal(url, directory)
-      return
+      return await streamExtractExternal(url, directory)
     } catch (error) {
       retryCount++
       core.debug(
@@ -59,8 +58,21 @@ async function streamExtract(url: string, directory: string): Promise<void> {
 export async function streamExtractExternal(
   url: string,
   directory: string
-): Promise<void> {
+): Promise<boolean> {
   const client = new httpClient.HttpClient(getUserAgentString())
+
+  const respHead = await client.head(url)
+  if (respHead.message.statusCode !== 200) {
+    throw new Error(
+      `Unexpected HTTP response from blob storage: ${respHead.message.statusCode} ${respHead.message.statusMessage}`
+    )
+  } else if (respHead.message.headers['content-type'] !== 'zip') {
+    core.debug(
+      `Invalid content-type: ${respHead.message.headers['content-type']}, skipping download`
+    )
+    return false
+  }
+
   const response = await client.get(url)
   if (response.message.statusCode !== 200) {
     throw new Error(
@@ -92,7 +104,7 @@ export async function streamExtractExternal(
       .pipe(unzip.Extract({path: directory}))
       .on('close', () => {
         clearTimeout(timer)
-        resolve()
+        resolve(true)
       })
       .on('error', (error: Error) => {
         reject(error)
@@ -140,13 +152,16 @@ export async function downloadArtifactPublic(
 
   try {
     core.info(`Starting download of artifact to: ${downloadPath}`)
-    await streamExtract(location, downloadPath)
-    core.info(`Artifact download completed successfully.`)
+    if (await streamExtract(location, downloadPath)) {
+      core.info(`Artifact download completed successfully.`)
+      return {downloadPath}
+    } else {
+      core.info(`Artifact download skipped.`)
+      return {downloadPath, skipped: true}
+    }
   } catch (error) {
     throw new Error(`Unable to download and extract artifact: ${error.message}`)
   }
-
-  return {downloadPath}
 }
 
 export async function downloadArtifactInternal(
@@ -192,13 +207,16 @@ export async function downloadArtifactInternal(
 
   try {
     core.info(`Starting download of artifact to: ${downloadPath}`)
-    await streamExtract(signedUrl, downloadPath)
-    core.info(`Artifact download completed successfully.`)
+    if (await streamExtract(signedUrl, downloadPath)) {
+      core.info(`Artifact download completed successfully.`)
+      return {downloadPath}
+    } else {
+      core.info(`Artifact download skipped.`)
+      return {downloadPath, skipped: true}
+    }
   } catch (error) {
     throw new Error(`Unable to download and extract artifact: ${error.message}`)
   }
-
-  return {downloadPath}
 }
 
 async function resolveOrCreateDirectory(

diff --git a/packages/artifact/src/internal/shared/interfaces.ts b/packages/artifact/src/internal/shared/interfaces.ts
@@ -86,6 +86,11 @@ export interface DownloadArtifactResponse {
    * The path where the artifact was downloaded to
    */
   downloadPath?: string
+
+  /**
+   * If the artifact download was skipped
+   */
+  skipped?: boolean
 }
 
 /**