Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dash to slash for asdf lts syntax #728

Closed

Conversation

doong-jo
Copy link

@doong-jo doong-jo commented Mar 26, 2023

Description:

asdf support lts-*, but setup-node support lts/*

스크린샷 2023-03-28 오전 12 30 09

When using the Node.js LTS code names in asdf and setup-node, there is a difference in the format of the code name. For example, asdf requires the code name with dashes included, while setup-node requires the code name with slashes included. This needs to be corrected.

Related issue:
#373

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@doong-jo doong-jo requested a review from a team as a code owner March 26, 2023 14:22
@doong-jo doong-jo force-pushed the support-lts-node-version-for-asdf branch from 2dd7314 to ed77a6b Compare March 26, 2023 14:23
@dmitry-shibanov
Copy link
Contributor

Hello @doong-jo. Thank you for your pull request. Could you please sync with the main branch and add a new syntax to versions.yml matrix ?

@doong-jo doong-jo closed this Dec 9, 2023
@doong-jo doong-jo force-pushed the support-lts-node-version-for-asdf branch from 9370701 to 5ef044f Compare December 9, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants