Avoid sbt cache being invalidated for a library that is only incrementing its own version
#564
+182,639
−47,289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
added a commit
to guardian/gha-scala-library-release-workflow
that referenced
this pull request
Dec 6, 2023
|
Interesting, perhaps it would be a good idea to have an action parameter that allows you to complete the pattern by default? This would give us finer control over the specifics of our projects. |
…ting it's own version While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232). This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving. As such, it would be great to exclude `version.sbt` files from the cache hash key. Background: `cache: sbt` was orginally introduced with actions#302
rtyley
added a commit
to guardian/gha-scala-library-release-workflow
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While working on
guardian/gha-scala-library-release-workflowI noticed that no matter how many times I ran the workflow,actions/setup-javawould always reportsbt cache is not found, even if there had been no substantial change in the project - simply that the version number inversion.sbt(the file used bysbt/sbt-release) had been incremented (as in guardian/play-secret-rotation@b215232).This meant that turning on
cache: sbtwould actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.As such, it would be great to exclude
version.sbtfiles from the cache hash key.Background:
cache: sbtwas originally introduced with #302 - cc @fmeriaux 🙇♂️Check list: