Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE to extend service containers #134

Conversation

katarzynainit
Copy link
Contributor

@katarzynainit katarzynainit commented Feb 12, 2024

Related to discussion under: #132

@nikola-jokic not sure how to upgrade ADR (what is your process) - awaiting your recommendation

@katarzynainit katarzynainit requested review from a team as code owners February 12, 2024 17:37
@nikola-jokic
Copy link
Contributor

What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller.
To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it 😄

Copy link
Contributor

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great!

@nikola-jokic nikola-jokic merged commit 7223e1d into actions:main Feb 20, 2024
3 checks passed
@katarzynainit
Copy link
Contributor Author

What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller. To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it 😄

Thanks, created #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants