Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to have a delay before retrying #355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mauriziovitale
Copy link

No description provided.

@mauriziovitale
Copy link
Author

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.

@mauriziovitale
Copy link
Author

Managed to override the retryAfterBaseValue to have a different delay

@joshmgross
Copy link
Member

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.

Could you explain your use case? When would you want a fixed retry delay instead of exponential delay?

@mauriziovitale
Copy link
Author

mauriziovitale commented Apr 5, 2023

It looks like there plugin-retry of octokit is using
const retryAfter = Math.pow((options.request.retryCount || 0) + 1, 2);
as value for retry.

Could you explain your use case? When would you want a fixed retry delay instead of exponential delay?

exponential is fine but I would like to have a starting point bigger than the default (1000)
for example I want to retry a call after 1min / 2min / 4min especially if you know that a cluster can take time to go up.

@RomaniukBohdan
Copy link

This feature would be useful. Is it planned to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants