Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up and add new input dataset (#16) #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robinlovelace-ate
Copy link
Contributor

No description provided.

@robinlovelace-ate robinlovelace-ate linked an issue Jul 19, 2023 that may be closed by this pull request
@robinlovelace-ate
Copy link
Contributor Author

Heads-up @stholder3 this PR aims to just add minimal example .GeoJSONs and slightly improve the visualisations. Not saying this is worth developing but note the Python code to read the inputs (and outputs from the overline() implementation in R) if you want to have a bash for learning/fun. If it's one day useful that would be a bonus!

Also heads-up @dabreegster I had a look at the R implementation and I do think it's a bit weird, can be substantially simplified and would love to help crack #15. I suspect that a Python implementation using polars could mimic what we do in the R code, worth a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more examples for tests and development
2 participants