Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-broken-summary-link #2213

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix-broken-summary-link #2213

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4a9d9a
fix-broken-summary-link
WilcoFiers Sep 2, 2024
6dc00f3
Add link destination to ensure it works properly
daniel-montalvo Sep 2, 2024
f9c74c2
Update summary-non-empty-accessible-name-2t702h.md
WilcoFiers Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions _rules/summary-non-empty-accessible-name-2t702h.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ acknowledgments:

## Applicability

This rule applies to HTML `summary` elements for which all the following is true:
This rule applies to HTML `summary` elements for which all the following are true:

- the element is [included in the accessibility tree][]; and
- the element works as the [summary button for its parent `details` element][details summary]; and
- the element has no [explicit role][], or the [explicit role][] is ignored due to a [presentational role conflict][].
- the element has no [explicit role][], or the [explicit role][] is ignored due to a [presentational role conflict][presentational roles conflict].

## Expectation

Expand Down Expand Up @@ -130,7 +130,7 @@ This `summary` element has no [accessible name][], or an accessible name with ju

#### Failed Example 2

This `summary` element has an [explicit role][] of `none`. However, it is [focusable][] (by default) which causes [Presentational Roles Conflict Resolution][]. It fails because it has an empty [accessible name][].
This `summary` element has an [explicit role][] of `none`. However, it is [focusable][] (by default) which causes [Presentational Roles Conflict Resolution][presentational roles conflict]. It fails because it has an empty [accessible name][].

```html
<details>
Expand Down Expand Up @@ -200,7 +200,7 @@ This `summary` element is hidden to everyone.
[explicit role]: #explicit-role 'Definition of explicit role'
[focusable]: #focusable 'Definition of focusable'
[included in the accessibility tree]: #included-in-the-accessibility-tree 'Definition of included in the accessibility tree'
[presentational roles conflict resolution]: https://www.w3.org/TR/wai-aria-1.2/#conflict_resolution_presentation_none 'Presentational Roles Conflict Resolution'
[presentational roles conflict]: https://www.w3.org/TR/wai-aria-1.2/#conflict_resolution_presentation_none 'Presentational Roles Conflict Resolution'
[details summary]: https://html.spec.whatwg.org/multipage/interactive-elements.html#summary-for-its-parent-details ' HTML 5 definition of summary for its parent details'
[97a4e1]: https://www.w3.org/WAI/standards-guidelines/act/rules/97a4e1/
[6cfa84]: https://www.w3.org/WAI/standards-guidelines/act/rules/6cfa84/
Loading