Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Element with presentational children has no focusable content" (rule 307n5z) - adding examples #2099
base: develop
Are you sure you want to change the base?
"Element with presentational children has no focusable content" (rule 307n5z) - adding examples #2099
Changes from 17 commits
aeafb90
5a07973
a75c7f8
f920a47
75a9878
81caf8a
22022c0
78642d0
e5f76d7
552c293
d161d08
d7ea3d3
9dd1ac6
527cfd9
9f81ae4
c8d188d
885d122
79268bb
58d6884
da4739a
6b0499d
6fe0e72
22ea612
b2c55fe
58cd998
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still believe the
button
should go away…From an implementer point of view, tools will report "Passed" rather than "Inapplicable" on that example. This is not a huge deal as it they are equivalent for consistency, but it still creates some weirdness.
We could have this example as a Passed Example. It would still fulfil the same goal (show that
table
role and its friends are not applicable) (because tools that apply the rule to them would report a Failed outcome). OTOH, I am not sure that thebutton
is adding much value to the example (the link is already a focusable element inside the table, we can have two links and the example is still working as intended).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair points, I'll discuss one-on-one some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Jym77
If we want this as an inapplicable example then we should not ask implementations to output "Passed". I agree with either solution proposed: make this a passed example or remove the
button
element.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this a minute ago by removing the button element.