Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_release_channel: Allow to have further tests flows with s… #17

Draft
wants to merge 35 commits into
base: 16.0-mig-stock_release_channel
Choose a base branch
from

Conversation

rousseldenis
Copy link
Member

…ome default values

guewen and others added 30 commits January 10, 2023 18:57
When using stock_dynamic_routing, the moves are reassigned to a new
picking (with StockMove._assign_picking()), and the original picking is
cancelled if it contains no moves anymore. As we want to keep

Note: maybe we should extend the assign picking mechanism to never
assign a move in a picking with a different release channel (channel is
empty or identical). As we extend it in
stock_picking_group_by_partner_by_carrier, it should be a new
dependency/glue module on it, or better, only extract the hook added
by stock_picking_group_by_partner_by_carrier for the domain in a base
module, used by both.
Reverts previous commit and re-assign the release channel in case
the released transfer has changed / moves have been released partially.
The rules result may change and we want them in the proper channel.
As these numbers are estimates (all moves even if not ready)
* Use new style of progress bars
* Add progressbar for showing progress of transfers *before* the
  outgoing one (chained ones)
* Improve CSS and labels
The "code" can be read only to base.group_system.
It will be used later the automatic release by commercial partner.
The initial automatic release allows to release a number of transfers N
up to a max of X in progress transfers at a time.

Introduce a selection of types of automatic release, with, alongside the
former "Max", a new grouping by commercial partner.

When using this automatic release, we take the first (by priority)
transfer ready to release, and all the transfers with the same
commercial partner, then release this whole group of transfers.
1. The Overall Progress of a Release Channel is always shown as
   a fractional number. This required changing the Javascript
   of the widget `progressbar` to add a new option to allow this.
   The idea is to submit this change to Odoo.

2. The Overall Progress computation has been changed, to be now:
   "Done Today" / sum("To Release", "To Do", "Done Today")
When order is confirmed, it triggers channel assign.
If the user that confirms the order doesn't have the correct rights,
then an error is raised.

Resolves: 2562
So normal users can process a sale order.
lmignon and others added 5 commits January 10, 2023 18:57
Organize release channels by warehouse.
Ease the configuration of release channel by picking types.
When the move is not generated by a SO, also assign the release channel
@rousseldenis
Copy link
Member Author

@lmignon

It seems that adding a dependency on sale is making tests failing : https://github.com/OCA/wms/actions/runs/4053352861/jobs/6973870131

This is due to sale_line_warn field which is not set (and is not a computed stored readonly False one).

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (16.0-mig-stock_release_channel@415cd2c). Click here to learn what that means.
The diff coverage is n/a.

@@                        Coverage Diff                        @@
##             16.0-mig-stock_release_channel      #17   +/-   ##
=================================================================
  Coverage                                  ?   95.21%           
=================================================================
  Files                                     ?       37           
  Lines                                     ?     2465           
  Branches                                  ?      231           
=================================================================
  Hits                                      ?     2347           
  Misses                                    ?       87           
  Partials                                  ?       31           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rousseldenis rousseldenis marked this pull request as draft January 31, 2023 11:58
@rousseldenis
Copy link
Member Author

Mmmh, wait, it seems related to stock_available_to_promise_release

@sbejaoui sbejaoui force-pushed the 16.0-mig-stock_release_channel branch from 415cd2c to f48f458 Compare March 7, 2023 14:39
@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch 2 times, most recently from 070037e to 160707d Compare March 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants