Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow MAX_IMPACTED_DOWNSTREAMS Override #4

Conversation

tjirab
Copy link
Contributor

@tjirab tjirab commented Feb 1, 2024

What is changed?

Allows MAX_IMPACTED_DOWNSTREAMS to be defined and used as environment variable.

Why?

To control depth in dependency checks.

@tjirab tjirab marked this pull request as ready for review February 1, 2024 08:28
Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, are you planning on increasing or decreasing this value?

src/impact_analysis.py Outdated Show resolved Hide resolved
@hsheth2 hsheth2 changed the title Feat: Allow MAX_IMPACTED_DOWNSTREAMS Override feat: Allow MAX_IMPACTED_DOWNSTREAMS Override Feb 1, 2024
@hsheth2 hsheth2 merged commit e546ed8 into acryldata:main Feb 1, 2024
1 check passed
@tjirab
Copy link
Contributor Author

tjirab commented Feb 2, 2024

Out of curiosity, are you planning on increasing or decreasing this value?

We are planning to decrease this value with the goal to expedite the runtime of the Github workflow.

@tjirab tjirab deleted the bs/20240201_enable-impacted-downstreams-override branch February 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants