Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master #279

Merged
merged 13 commits into from
Mar 1, 2024
Merged

merge master #279

merged 13 commits into from
Mar 1, 2024

Conversation

RyanHolstien
Copy link

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.80%. Comparing base (0a8b336) to head (3284235).
Report is 6 commits behind head on master.

Files Patch % Lines
.../datahub/ingestion/source/schema_inference/json.py 61.53% 5 Missing ⚠️
...ingestion/src/datahub/emitter/mcp_patch_builder.py 75.00% 1 Missing ⚠️
...ngestion/src/datahub/ingestion/source/s3/source.py 66.66% 1 Missing ⚠️
metadata-ingestion/src/datahub/specific/datajob.py 0.00% 1 Missing ⚠️
.../src/datahub/sql_parsing/sql_parsing_aggregator.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   74.79%   74.80%           
=======================================
  Files         484      484           
  Lines       48207    48223   +16     
=======================================
+ Hits        36058    36071   +13     
- Misses      12149    12152    +3     
Flag Coverage Δ
airflow 66.61% <ø> (ø)
airflow-plugin-v1 44.16% <ø> (ø)
airflow-plugin-v2 57.82% <ø> (ø)
pytest-testIntegrationBatch0 57.93% <75.51%> (-0.02%) ⬇️
pytest-testIntegrationBatch1 39.03% <57.14%> (-0.02%) ⬇️
pytest-testIntegrationBatch2 40.01% <57.14%> (-0.02%) ⬇️
pytest-testQuick 43.72% <75.51%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanHolstien RyanHolstien merged commit 5f74d4f into acryldata:master Mar 1, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants