feat: add extradeploy like bitnami #495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there any progress on this PR? it's useful for additional jobs after the entire deployment. |
added 2 commits
September 19, 2024 14:34
# Conflicts: # charts/datahub/Chart.yaml # charts/datahub/templates/_helpers.tpl
|
This PR is stale. We will close it in 30 days if there is no comment or activity. If you want feedback but not able to get it on github please head to #contribute channel in slack at https://slack.datahubproject.io. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining the list of k8s resources that users need in relation to datahub in extradeploy, such as serviceAccount, role, rolebinding, and so on.
I noticed that the Bitnami repositories include an extraDeploy feature, as seen in this example. However, I couldn't find a similar feature in DataHub, so I copied some code from Bitnami . Unfortunately, I found this issue after completing my implementation. After reviewing this code, it seems to follow Bitnami's approach and names it extraDeploy too, but it not be applied by datahube cause of the "extraDeloy" name.
Checklist