Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(registry): Revert default schema registry to Confluent's Schema Registry #349

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/datahub/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: A Helm chart for LinkedIn DataHub
type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
version: 0.2.181
version: 0.2.182
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 0.10.5
Expand Down
6 changes: 3 additions & 3 deletions charts/datahub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -486,10 +486,10 @@ global:
# replicationFactor: 3
schemaregistry:
# GMS Implementation - `url` configured based on component context
type: INTERNAL
# type: INTERNAL
# Confluent Kafka Implementation
# type: KAFKA
# url: "http://prerequisites-cp-schema-registry:8081"
type: KAFKA
url: "http://prerequisites-cp-schema-registry:8081"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch


# Glue Implementation - `url` not applicable
# type: AWS_GLUE
Expand Down
Loading