-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/get tx status #7
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good ! Left some nits and other remarks. We can also split up some work if that's too much. Just lmk
packages/sdk/src/utils/fetch.ts
Outdated
@@ -1,4 +1,4 @@ | |||
export const fetchAcross = globalThis.fetch.bind(globalThis); | |||
export const fetchAcross = globalThis.fetch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize now that the API in Node identical to the web API, so we can probably remove this completely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looking awesome 👍 Left only nits
Co-authored-by: Dong-Ha Kim <[email protected]>
No description provided.