add eth-weth example to readme #53
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| export function generateStakeAction( | ||
| userAddress: Address, | ||
| value: bigint, | ||
| ): CrossChainAction { | ||
| return { | ||
| target: STAKE_CONTRACT.address, | ||
| callData: generateStakeCallData(userAddress), | ||
| value, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
deleting unused function
packages/sdk/README.md
Outdated
|
|
||
| > This follows the logic in the example app. | ||
|
|
||
| To implement this feature, we need to bridge either ETH or WETH from our origin chain to our destination chain. Across will always send WETH to the recipient on the destination chain, **unless the recipient is an EOA**. For our use-case, we want to stake native ETH, moreover we want to do this in one step. For this we recommend using Across's MulticallHandler contract (or deploying your own). |
There was a problem hiding this comment.
Please check this information is accurate
Yeah I agree this is too verbose. The example app uses eth/weth precisely because it can be a confusing implementation since you have to update calldata AND value when building your cross-chain actions. So maybe it does make sense to just use that example int he README? |
Yeah, agree let's do that. In future iterations, we can add other examples as well. |
closes ACX-3033