Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test framework #5

Merged
merged 5 commits into from
Sep 4, 2024
Merged

feat: add test framework #5

merged 5 commits into from
Sep 4, 2024

Conversation

gsteenkamp89
Copy link
Collaborator

@gsteenkamp89 gsteenkamp89 commented Sep 4, 2024 •
edited
Loading

closes ACX-2625

  • adds vitest framework
  • adds prettier to sdk and example app
  • adds scripts to build/lint and format entire repo
  • adds script to check the types of the sdk dist output after build using @arethetypeswrong
  • adds CI workflow to build/lint and test on pushes/pr to master
  • change to esm only build (we can change this later if we want to)

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
toolkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 2:24pm

@gsteenkamp89 gsteenkamp89 requested a review from dohaki September 4, 2024 13:23
@linear Linear
Copy link

linear bot commented Sep 4, 2024

ACX-2625 Add Test boilerplate

The scope of this task is to add the necessary framework, scripts and gh action workflows for testing the sdk (unit). Thereafter tests can be added piecemeal

dohaki
dohaki approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Might need to rebase/merge though

@gsteenkamp89 gsteenkamp89 merged commit 95050e2 into master Sep 4, 2024
3 checks passed
@gsteenkamp89 gsteenkamp89 deleted the feat/add-test-framework branch September 4, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dohaki dohaki dohaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteenkamp89 @dohaki