refactor(QueryBase): Remove constructors in derived classes #808
+8
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor calls in AlephZeroQueries and PolygonQueries are not useful since the `getTokenPrice()` class function is the main changed logic from the parent `QueryBase` class. We can reduce LOC in the repo by removing these constructors. This was partially motivated by work on #801 where I had to modify these constructors because the `QueryBase` constructor changed
james-a-morris
approved these changes
Dec 27, 2024
nicholaspai
commented
Jan 2, 2025
| coingeckoProApiKey, | ||
| logger | ||
| fixedGasPrice[chainId], | ||
| "usd" |
There was a problem hiding this comment.
I'm pretty sure we can just pass through and use the parent class's constructor here and therefore delete the derived construcotr in PolygonQueries and AlephZeroQueries. The only thing different in the child's constructor was changing the coingeckoBaseCurrency, which we can instead just explicitly state here when constructing the child class
pxrl
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor calls in AlephZeroQueries and PolygonQueries are not useful since the
getTokenPrice()class function is the main changed logic from the parentQueryBaseclass. We can reduce LOC in the repo by removing these constructors. Additionally, we should be able to just use the parentQueryBase'sconstructordirectly.This was partially motivated by work on #801 where I had to modify these constructors because the
QueryBaseconstructor changed