refactor(SpokePoolClient): Move findDeposit to helper function file #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function `findDeposit` is only used by `queryHistoricalDepositForFill`, a utility function. I propose moving this helper function closer to the helper function as it doesn't need to be a client level function. Though, it does make lots of spoke pool client calls but I see it just as intuitive to pass in the relevant spoke pool client into the function. The function effecitvely "finds a deposit" using a spoke pool client's memory.
nicholaspai
requested review from
mrice32,
bmzig,
james-a-morris,
pxrl and
dohaki
pxrl
reviewed
Dec 17, 2024
| @@ -125,6 +127,73 @@ export async function queryHistoricalDepositForFill( | |||
| }; | |||
| } | |||
|
|
|||
| export async function findDeposit( | |||
There was a problem hiding this comment.
Also RE #798 (comment), I think this will make it more difficult to handle an SVM integration, because the caller (or this function) will need to consider whether the target chain is evm or svm.
So in general my preference would be to route calls via the SpokePoolClient, and have it implement pointers to the correct underlying interfaces depending on whether it's evm or svm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function
findDepositis only used byqueryHistoricalDepositForFill, a utility function. I propose moving this helper function closer to the helper function as it doesn't need to be a client level function. Though, it does make lots of spoke pool client calls but I see it just as intuitive to pass in the relevant spoke pool client into the function. The function effecitvely "finds a deposit" using a spoke pool client's memory.