Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TokenUtils): Support identifying Zora USDzC #765

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Nov 5, 2024

This PR adds missing support for Zora USDC to a TokenUtils utility function. I spotted the need for this because the relayer was refusing to fill a USDzC -> Arbitrum USDC.e deposit and complained that it implied a token swap.

I don't feel great about this function; we generally need:

  • A new implementation that does not rely on unique token addresses.
  • A consolidation of various "is this bridged USDC?" functionalities that are scattered around the various repos.

I don't feel great about this function; we generally need:
- A new implementation that does not rely on unique token addresses.
- A consolidation of various "is this bridged USDC?" functionalities
  that are scattered around the various repos.
@pxrl pxrl requested review from dohaki, gsteenkamp89 and bmzig November 5, 2024 20:46
Copy link
Contributor

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants