refactor

across-protocol · Jan 2, 2025 · 21821ca · 21821ca
1 parent 4980b22
commit 21821ca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/gasPriceOracle/adapters/polygon.ts b/src/gasPriceOracle/adapters/polygon.ts
@@ -68,23 +68,20 @@ export class PolygonGasStation extends BaseHTTPAdapter {
   }
 }
 
-export class MockRevertingPolygonGasStation extends PolygonGasStation {
+class MockRevertingPolygonGasStation extends PolygonGasStation {
   getFeeData(): Promise<GasPriceEstimate> {
     throw new Error();
   }
 }
 
-export class MockPolygonGasStation extends PolygonGasStation {
-  static BASE_FEE(): BigNumber {
-    return parseUnits("12", 9);
-  }
-  static PRIORITY_FEE(): BigNumber {
-    return parseUnits("1", 9);
-  }
+export const MockPolygonGasStationBaseFee = parseUnits("12", 9);
+export const MockPolygonGasStationPriorityFee = parseUnits("1", 9);
+
+class MockPolygonGasStation extends PolygonGasStation {
   getFeeData(): Promise<GasPriceEstimate> {
     return Promise.resolve({
-      maxPriorityFeePerGas: MockPolygonGasStation.PRIORITY_FEE(),
-      maxFeePerGas: MockPolygonGasStation.BASE_FEE().add(MockPolygonGasStation.PRIORITY_FEE()),
+      maxPriorityFeePerGas: MockPolygonGasStationPriorityFee,
+      maxFeePerGas: MockPolygonGasStationBaseFee.add(MockPolygonGasStationPriorityFee),
     });
   }
 }

diff --git a/test/GasPriceOracle.test.ts b/test/GasPriceOracle.test.ts
@@ -8,7 +8,7 @@ import { getGasPriceEstimate } from "../src/gasPriceOracle";
 import { BigNumber, bnZero, parseUnits } from "../src/utils";
 import { assertPromiseError, expect, makeCustomTransport, randomAddress } from "../test/utils";
 import { MockedProvider } from "./utils/provider";
-import { MockPolygonGasStation } from "../src/gasPriceOracle/adapters/polygon";
+import { MockPolygonGasStationBaseFee, MockPolygonGasStationPriorityFee } from "../src/gasPriceOracle/adapters/polygon";
 dotenv.config({ path: ".env" });
 
 const stdLastBaseFeePerGas = parseUnits("12", 9);
@@ -190,9 +190,9 @@ describe("Gas Price Oracle", function () {
     });
 
     expect(maxFeePerGas).to.equal(
-      MockPolygonGasStation.BASE_FEE().mul(baseFeeMultiplier).add(MockPolygonGasStation.PRIORITY_FEE())
+      MockPolygonGasStationBaseFee.mul(baseFeeMultiplier).add(MockPolygonGasStationPriorityFee)
     );
-    expect(maxPriorityFeePerGas).to.equal(MockPolygonGasStation.PRIORITY_FEE());
+    expect(maxPriorityFeePerGas).to.equal(MockPolygonGasStationPriorityFee);
     delete process.env["TEST_POLYGON_GAS_STATION"];
   });
   it("Ethers Polygon GasStation: Fallback", async function () {