fix: /deposits, exclude pending deposits with amount 0 (#212)

* fix: /deposits, exclude pending deposits with amount 0 * Fix * Fix tests * Update service.ts
across-protocol · Jan 30, 2023 · 582eacf · 582eacf
1 parent 683d72d
commit 582eacf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/modules/deposit/service.ts b/src/modules/deposit/service.ts
@@ -97,6 +97,7 @@ export class DepositService {
       [deposits, total] = await this.depositRepository
         .createQueryBuilder("d")
         .where("d.status = :status", { status })
+        .andWhere("d.amount > 0")
         .andWhere("d.depositDate > NOW() - INTERVAL '1 days'")
         .andWhere(`d.depositRelayerFeePct * :multiplier >= d.suggestedRelayerFeePct`, {
           multiplier: this.appConfig.values.suggestedFees.deviationBufferMultiplier,

diff --git a/test/deposit.e2e-spec.ts b/test/deposit.e2e-spec.ts
@@ -25,12 +25,12 @@ describe("GET /deposits", () => {
   // filled deposits with depositIds 10 - 19 and ascending depositDate
   const FILLED_DEPOSITS = mockManyDepositEntities(10, {
     depositIdStartIndex: 10,
-    overrides: { status: "filled", depositorAddr: depositorAddress },
+    overrides: { status: "filled", depositorAddr: depositorAddress, amount: "10", filled: "10" },
   });
   // pending deposits with depositIds 20 - 29 and ascending depositDate
   const PENDING_DEPOSITS = mockManyDepositEntities(10, {
     depositIdStartIndex: 20,
-    overrides: { status: "pending", depositorAddr: depositorAddress },
+    overrides: { status: "pending", depositorAddr: depositorAddress, amount: "10" },
   });
 
   beforeAll(async () => {