fix(Dataworker): Cannot fund DonationBox using MulticallerClient #1975
+91
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MulticallerClient has [logic](https://github.com/across-protocol/relayer/blob/40b0c7971a3548a0499e7fc5990d150437c527fb/src/clients/MultiCallerClient.ts#L361) that batches transactions together and attempts to `multicall()` them. This works normally with the `HubPool` and `SpokePool` which extend the `Multicaller()` interface. However, we can't use this logic to make calls on ERC20's like we are doing to fund the `DonationBox`. Instead, we either need to update the `MulticallerClient` to handle cases where transactions are not multicall-able, or we can send these transactions to the `TransactionClient`. In this PR, I added a new method `simulateAndSubmit` to the `TransactionClient` that the Dataworker uses to `transfer` custom gas tokens to the DonationBox.
nicholaspai
requested review from
mrice32,
pxrl,
james-a-morris and
dohaki
as code owners
nicholaspai
commented
Dec 30, 2024
melisaguevara
previously approved these changes
Dec 30, 2024
bmzig
reviewed
Dec 31, 2024
bmzig
previously approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MulticallerClient has logic that batches transactions together and attempts to
multicall()them. This works normally with theHubPoolandSpokePoolwhich extend theMulticaller()interface.However, we can't use this logic to make calls on ERC20's like we are doing to fund the
DonationBox. Instead, we either need to update theMulticallerClientto handle cases where transactions are not multicall-able, or we can send these transactions to theTransactionClient.In this PR, I added a new method
simulateAndSubmitto theTransactionClientthat the Dataworker uses totransfercustom gas tokens to the DonationBox.