Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable Ink in the relayer #1966

Merged
merged 5 commits into from
Dec 30, 2024
Merged

feat: enable Ink in the relayer #1966

merged 5 commits into from
Dec 30, 2024

Conversation

james-a-morris
Copy link
Contributor

Enables the Ink chain in the relayer.

@linear Linear
Copy link

linear bot commented Dec 23, 2024

ACX-3460 Update relayer repository

@bmzig
Copy link
Contributor

bmzig commented Dec 23, 2024

Since it doesn't look like we are supporting any USD stablecoin on Ink right away, you probably need to add WETH as an entry here:

relayer/src/clients/ProfitClient.ts

Line 605 in e9ad355

const testSymbols = {

@james-a-morris
improve: multipliers
1ce7d09 
Signed-off-by: james-a-morris <[email protected]>
@james-a-morris
Copy link
Contributor Author

Since it doesn't look like we are supporting any USD stablecoin on Ink right away, you probably need to add WETH as an entry here:

relayer/src/clients/ProfitClient.ts

Line 605 in e9ad355

const testSymbols = {

1ce7d09

@james-a-morris james-a-morris requested a review from bmzig December 23, 2024 21:38
bmzig
bmzig approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the address of the output oracle

@james-a-morris james-a-morris requested a review from pxrl December 27, 2024 19:15
bmzig
bmzig previously approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sounds right that we don't need the output oracle for updated OP chains. I've tried running finalizations on Base/Optimism without the address and they work fine.

nicholaspai
nicholaspai reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few q's

@james-a-morris james-a-morris merged commit 40b0c79 into master Dec 30, 2024
4 checks passed
@james-a-morris james-a-morris deleted the james/acx-3460-update-relayer-repository branch December 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspai nicholaspai nicholaspai approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@dohaki dohaki Awaiting requested review from dohaki dohaki is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

@bmzig bmzig Awaiting requested review from bmzig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@james-a-morris @bmzig @nicholaspai @pxrl