Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show invalid amt when there's an amount #922

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

james-a-morris
Copy link
Contributor

The UI has a bug where it marks an empty input field with a red "please input positive number" error. The UI should go back to the unchanged state when a user removed their amount.

Steps to reproduce.

  1. Visit https://across.to/bridge
  2. Enter a number into the amount field.
  3. Remove the amount entirely

You will be left with this:
image

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 4:28pm
goerli-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 4:28pm

Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-a-morris james-a-morris merged commit 4a65875 into master Nov 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants