fix: throw speed up mutation if depositor does not match signer #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACX-1667 Speed-ups are ineffective on SpokePoolVerifier deposits
Problem: When ETH deposits are routed via the SpokePoolVerifier, only the SpokePoolVerifier is able to approve a speed-up. The FE still offers the ability to submit a speed-up, but the SpokePoolClient just ignores it because the depositor addresses do not match. I'm not sure how speed-ups should be handled in this instance, since the SpokePoolVerifier is forced to be the depositor, and it cannot approve speed-ups. The FE should perhaps add extra verification to prevent the user from signing a speed-up if their EOA does not match the depositor address in the related deposit event. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrice32
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ACX-1667