feat: track deposit network mismatch #879
Conversation
ACX-1617 Possible FE wallet de-sync on deposit
A user has reported a deposit "de-sync", where the deposit txn was submitted on the wrong chain. In this case there is evidence of the FE having experienced state inconsistencies internally. Since this was a USDC deposit, only a small amount of gas was lost (~.07$ in ETH). The user is not requesting any refund. Discord ticket: https://discord.com/channels/887426921892315137/1163013198170034267 Deposit: USDC Optimism → zkSync, was submitted on the destination chain: https://explorer.zksync.io/tx/0x69b35a8fb22335e63b257bd8459a1234358152d80bba138aa265f7bce93d351b The "Deposit Successful" screen shows a misalignment between the intended deposit chain (Optimism) and the "Track in Explorer" link (zkSync). Normally these should be equal. For reference, the "deposit successful" page should show: 2023-10-16-135032_707x812_scrot.png The Amplitude event records for this deposit appear to indicate that the wallet was connected to zkSync, but that the user received quotes for Optimism → zkSync: 2023-10-16-135636_1302x658_scrot.png 2023-10-16-135646_1297x658_scrot.png 2023-10-16-135657_1276x666_scrot.png 2023-10-16-135716_1367x670_scrot.png Possible contributing factor?
2023-10-16-141230_1355x262_scrot.png 2023-10-16-141242_1151x356_scrot.png Full deposit pending page: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const signerChainId = await signer.getChainId(); | ||
| if (signerChainId !== fromChain) { |
There was a problem hiding this comment.
Is this change needed or is it for readability?
There was a problem hiding this comment.
I wanted to track the signer chain id also in the amplitude event here https://github.com/across-protocol/frontend-v2/pull/879/files#diff-5d22ab6b9a7272e68f42731b880e896d1671416cc379fcf34bf6106cc5b9658eR246. To prevent another async call, I am storing the value in this variable
Closes ACX-1617