fix: 🐛 remove ability to specify backup capital cost fee #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't be allowed to set a backup default cost config fee. This is indicative of a misconfured capital cost setting. We should have an intentional default for a given token or else we should fail.
ACX-1618 Remove default flat cost config fee
The Default Flat Capital Cost Config fee is strictly meant to provide a fallback if the capital cost config doesn't contain all necessary tokens. Let's remove that and enforce a start-up error. |
james-a-morris
requested review from
mrice32 and
nicholaspai
and removed request for
mrice32
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nicholaspai
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be allowed to set a backup default cost config fee. This is indicative of a misconfured capital cost setting. We should have an intentional default for a given token or else we should fail.
A failure condition has been added to across-protocol/sdk#430 and we will need to bump the SDK before we merge this change.