fix: MetaMask browser app crash on wallet change #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACX-1532 Change Wallets - error "something went wrong" must reload to change
In MM browser, when you connect and change to a different wallet, the app shows this error |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@james-a-morris Yep, exactly! Even though we have Sentry configured, a lot of browsers block requests to Sentry. So it's very hard to debug fatal crashes. By showing the error in the UI directly, we can have a bit more details from potentially provided screenshots |
james-a-morris
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ACX-1532
When changing the account in the MetaMask mobile browser, the
wallet.accountsarray is empty for a short period of time. This led to a fatal crash of the app.